This repository has been archived by the owner on Mar 8, 2023. It is now read-only.
MAPSJS-3047, Split theme to stable and unstable parts #2331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriiHeonia
force-pushed
the
MAPSJS-3047
branch
3 times, most recently
from
bd26de8
to
0b1114f
Compare
Codecov Report
@@ Coverage Diff @@
## master #2331 +/- ##
=======================================
Coverage 68.30% 68.30%
=======================================
Files 319 319
Lines 27815 27815
Branches 6237 6237
=======================================
+ Hits 18999 19000 +1
+ Misses 8816 8815 -1
Continue to review full report at Codecov.
|
ThFischer
reviewed
Nov 2, 2021
AndriiHeonia
force-pushed
the
MAPSJS-3047
branch
from
0b1114f
to
ea085ae
Compare
ThFischer
previously approved these changes
Nov 2, 2021
AndriiHeonia
force-pushed
the
MAPSJS-3047
branch
from
ea085ae
to
6c5adb3
Compare
AndriiHeonia
force-pushed
the
MAPSJS-3047
branch
from
6c5adb3
to
e37d404
Compare
|
@AndriiHeonia I just updated the CI to use node 14 from node 12. So you see those new tests. You can rebase your changes to add the new commits and push once more. |
AndriiHeonia
force-pushed
the
MAPSJS-3047
branch
from
e37d404
to
fe4744f
Compare
dbacarel
suggested changes
Nov 15, 2021
Signed-off-by: Andrii Heonia <andrii.heonia@here.com>
AndriiHeonia
force-pushed
the
MAPSJS-3047
branch
from
fe4744f
to
c3ee308
Compare
dbacarel
approved these changes
Nov 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andrii Heonia andrii.heonia@here.com