AAA-5204 :: here-aaa-java-sdk does not support adding X-Correlation-I… #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenmccracken
requested changes
Jun 27, 2019
here-oauth-client/src/main/java/com/here/account/oauth2/AccessTokenRequest.java
Show resolved
Hide resolved
here-oauth-client/src/main/java/com/here/account/oauth2/AccessTokenRequest.java
Outdated
Show resolved
Hide resolved
here-oauth-client/src/main/java/com/here/account/oauth2/HereAccount.java
Outdated
Show resolved
Hide resolved
kenmccracken
requested changes
Jul 1, 2019
here-oauth-client/src/main/java/com/here/account/oauth2/HereAccount.java
Outdated
Show resolved
Hide resolved
here-oauth-client/src/main/java/com/here/account/client/Client.java
Outdated
Show resolved
Hide resolved
here-oauth-client/src/main/java/com/here/account/oauth2/HereAccount.java
Show resolved
Hide resolved
…d as a header on the token request Signed-off-by: Steven Walton <steve.walton@here.com>
kenmccracken
approved these changes
Jul 11, 2019
There was a problem hiding this comment.
The additional tests look good.
I think we should also make the correlationId available in the AccessTokenResponse object, as it is a platform primitive. I've logged the response side as a separate issue #65
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d as a header on the token request