Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check if an operation was cancelled #1338

Merged
merged 1 commit into from
Jun 10, 2022
Merged

Conversation

dudnyk
Copy link
Contributor

@dudnyk dudnyk commented Jun 10, 2022

Add check if the pointer exists to prevent calling
OnPrefetchCompletedin in case an operation is cancelled.

Relates-To: OLPEDGE-2746

Signed-off-by: Yevhenii Dudnyk ext-yevhenii.dudnyk@here.com

@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #1338 (bfb84cb) into master (e0ba039) will decrease coverage by 0.0%.
The diff coverage is 100.0%.

❗ Current head bfb84cb differs from pull request most recent head e16e864. Consider uploading reports for the commit e16e864 to get more accurate results

@@           Coverage Diff            @@
##           master   #1338     +/-   ##
========================================
- Coverage    86.1%   86.0%   -0.0%     
========================================
  Files         381     381             
  Lines       13540   13540             
========================================
- Hits        11655   11651      -4     
- Misses       1885    1889      +4     
Impacted Files Coverage Δ
...lp-cpp-sdk-dataservice-read/src/DownloadItemsJob.h 100.0% <100.0%> (ø)
olp-cpp-sdk-core/src/cache/DiskCacheEnv.cpp 72.7% <0.0%> (-6.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0ba039...e16e864. Read the comment docs.

Add check if the pointer exists to prevent calling
OnPrefetchCompletedin in case an operation is cancelled.

Relates-To: OLPEDGE-2746

Signed-off-by: Yevhenii Dudnyk <ext-yevhenii.dudnyk@here.com>
@dudnyk dudnyk merged commit 6ae2ab2 into master Jun 10, 2022
@dudnyk dudnyk deleted the task/olpedge-2746_cancel branch June 10, 2022 11:31
dudnyk added a commit that referenced this pull request Jun 16, 2022
This reverts commit 6ae2ab2
and c0c6445

Relates-To: OLPEDGE-2746

Signed-off-by: Yevhenii Dudnyk <ext-yevhenii.dudnyk@here.com>
@nplakhtii nplakhtii mentioned this pull request Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants