Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeJS 18x support #518

Merged
merged 1 commit into from
May 10, 2024
Merged

NodeJS 18x support #518

merged 1 commit into from
May 10, 2024

Conversation

OleksiiZubko
Copy link
Collaborator

@OleksiiZubko OleksiiZubko commented Apr 29, 2024

  • Were stopped supporting nodejs versions less than 18.x.
  • Remove node_fetch from the dependencies.

Relates-To: OLPEDGE-2889

@OleksiiZubko OleksiiZubko force-pushed the update-nodejs branch 2 times, most recently from ed1c971 to 4b962ce Compare April 29, 2024 19:32
@OleksiiZubko OleksiiZubko force-pushed the update-nodejs branch 4 times, most recently from 7ae2a77 to bc97db6 Compare April 30, 2024 22:01
@ystefinko ystefinko force-pushed the update-nodejs branch 5 times, most recently from 9983bd6 to 9cf2f0e Compare May 7, 2024 08:48
Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.1118%. Comparing base (9ffcf8f) to head (227ccb5).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##             master       #518   +/-   ##
===========================================
  Coverage   90.1118%   90.1118%           
===========================================
  Files            82         82           
  Lines          2953       2953           
  Branches        333        333           
===========================================
  Hits           2661       2661           
  Misses          136        136           
  Partials        156        156           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OleksiiZubko OleksiiZubko changed the title DRAFT: NodeJS 18x support NodeJS 18x support May 8, 2024
ystefinko
ystefinko previously approved these changes May 9, 2024
@here/olp-sdk-fetch/README.md Outdated Show resolved Hide resolved
@here/olp-sdk-fetch/README.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
HalynaDumych
HalynaDumych previously approved these changes May 9, 2024
Drop suporting nodejs < 18x.
Remove node_fetch from the dependencies.
Update development dependencies.

Relates-To: OLPEDGE-2889

Signed-off-by: Oleksii Zubko <ext-oleksii.zubko@here.com>
@OleksiiZubko OleksiiZubko merged commit ff0f2f7 into master May 10, 2024
9 checks passed
@OleksiiZubko OleksiiZubko deleted the update-nodejs branch May 10, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants