This repository has been archived by the owner on Sep 5, 2023. It is now read-only.
add autosuggest api #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sackh
suggested changes
Aug 18, 2021
sackh
suggested changes
Aug 19, 2021
| assert resp2.items | ||
|
|
||
| resp3 = ls.autosuggest(q="res", limit=5, search_in_circle=search_in_circle1, lang=["en"]) | ||
| resp3 = ls.autosuggest(query="res", limit=5, search_in_circle=search_in_circle1, lang=["en"]) | ||
| assert resp3.items | ||
|
|
||
| resp4 = ls.autosuggest( |
There was a problem hiding this comment.
assertions missing for resp4 can we verify change in results after passing, show and politcal_view ?
tests/test_ls.py
Outdated
| assert resp2.items | ||
|
|
||
| resp3 = ls.autosuggest(q="res", limit=5, search_in_circle=search_in_circle1, lang=["en"]) | ||
| resp3 = ls.autosuggest(query="res", limit=5, search_in_circle=search_in_circle1, lang=["en"]) |
There was a problem hiding this comment.
please add assertion for limit parameter if results returned are limited to 5
sackh
approved these changes
Aug 20, 2021
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.