Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove old socket interface #681

Merged
merged 3 commits into from
Jun 3, 2023
Merged

remove old socket interface #681

merged 3 commits into from
Jun 3, 2023

Conversation

stlankes
Copy link
Contributor

@stlankes stlankes commented Mar 19, 2023 •
edited by mkroening
Loading

Fixes #542.

Restructure the code to increase the readability and remove old socket interface.

@stlankes stlankes marked this pull request as draft March 19, 2023 10:14
@stlankes stlankes requested a review from mkroening March 19, 2023 10:14
mkroening
mkroening approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@mkroening mkroening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

@stlankes stlankes marked this pull request as ready for review May 5, 2023 11:56
@stlankes stlankes added this pull request to the merge queue Jun 3, 2023
Merged via the queue into hermit-os:master with commit a31294e Jun 3, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkroening mkroening mkroening approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make network syscalls extern "C"
2 participants
@stlankes @mkroening