Tag cleanup #440
Merged
Tag cleanup #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made first changes to remove Tag.MATCHADDRESS (work-in-progress)
Changed Tag.VISIBLE from "V" to "_" (replaces the old Tag.ANY) Changed Tag.RMW from "__RMW" back to "RMW" (used by LKMM)
dartagnan/src/main/java/com/dat3m/dartagnan/program/event/Tag.java
Outdated
Show resolved
Hide resolved
dartagnan/src/main/java/com/dat3m/dartagnan/program/event/core/rmw/RMWStoreExclusive.java
Show resolved
Hide resolved
Updated compilation of Lock/Unlock to use RMWLoad/RMWStore rather than plain one's with LOCK tags.
Removed internal usages of Tag.Linux.LOCK_READ
…rectly). Removed svcomp-locks.cat.
hernanponcedeleon
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up our usage of Tags:
(1) Dubious usages of tags got replaced (e.g.,
e.is(Tag.JUMP)got replaced bye instanceof CondJump)(2) Unused Tags got removed
(3) Tags that are used only internally and should not be exposed to CAT are now prefixed by "__" (e.g. "__BOUND").
In order to implement change (1), some code changes have been made, but none of which should affect functionality.
There is a slight change in the semantics of
ctrlDirectin that it does not relate unconditional jumps to any events anymore (this should not affect the semantics ofctrl = idd+;ctrlDirect & (RxV)since unconditional jumps never had incomingiddedges).