3.12.1 Release + don't try to backfill notification sender ids after username changes #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lugehorsam
changed the title
lugehorsam
changed the title
novabyte
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user changes their account username, their old records for tournaments, notifications etc., won't be updated to reflect the new username.
To mitigate this, upon listing records, we automatically compare the record username to the session username and if they differ, we assume it's because of a username change and correct the record username to the session username: #148
However, for notifications, the sender id can differ from the user ID simply by being from another user. So we just don't have a way to know if the user sent it to themselves but with an older username, or if it was sent to them from another user.