Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.12.1 Release + don't try to backfill notification sender ids after username changes #176

Merged
merged 2 commits into from
May 30, 2024
Merged

3.12.1 Release + don't try to backfill notification sender ids after username changes #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b53f12c
don't try to backfill notif sender ids after username changes
lugehorsam May 30, 2024
4e8f8d4
release notes
lugehorsam May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) a

## [Unreleased]

## [3.12.1] - 2024-05-30
### Fixed
- Nakama: Fixed an issue where notifications from other users could appear as if they were sent by the recipient user.
- Nakama: Fixed a potential `NullReferenceException` that could occur when passing a `null` username to `IClient.UpdateAccountAsync`.

## [3.12.0] - 2024-04-08
### Added
- Satori: Added `IApiLiveEvent.Id` for accessing live event identifiers.
Expand Down
8 changes: 0 additions & 8 deletions Nakama/Client.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -947,14 +947,6 @@ public async Task DeleteTournamentRecordAsync(ISession session, string tournamen
() => _apiClient.ListNotificationsAsync(session.AuthToken, limit, cacheableCursor, canceller),
new RetryHistory(session, retryConfiguration ?? GlobalRetryConfiguration, canceller));

foreach (var notification in response.Notifications)
{
if (!session.Username.Equals(notification.SenderId) && notification is ApiNotification n)
{
n.SenderId = session.UserId;
}
}

return response;
}

Expand Down
Loading