Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New types added to TinyJson #51

Merged

Conversation

fatihyldrim
Copy link

TinyJson does not work when object has a DateTime and Guid. The type conversions added to TinyJson. Also tests are modified.

@lugehorsam
Copy link
Contributor

Nice contribution @fatihyldrim -- I wanted to check if there was a reason why you couldn't serialize this as a string?

Because of take all the values of the DateTime
All known types tested from object-json to json-object
@fatihyldrim
Copy link
Author

Thank you @lugehorsam -- My entities and DTOs contain datetime and guid types to provide ease of operations. And I added these types for serialize and deserialize directly from DTOs.

I added another test function to be clearer. Let me know if there is more efficient way.

@lugehorsam
Copy link
Contributor

👍

@lugehorsam lugehorsam merged commit 8889f86 into heroiclabs:luke/json-interface Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants