Use fixed number of query args in StorageReadObjects #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redbaron
force-pushed
the
storage-read-multi-args
branch
from
8097aa9
to
bf7494f
Compare
redbaron
commented
Jul 18, 2023
zyro
requested changes
Jul 18, 2023
server/core_storage.go
Outdated
| } else { | ||
| whereClause += fmt.Sprintf(" (collection = $%v AND key = $%v AND user_id = $%v AND (read = 2 OR (read = 1 AND user_id = $%v))) ", l+1, l+2, l+3, l+4) | ||
| params = append(params, id.Collection, id.Key, id.UserId, caller) | ||
| reqUid = uuid.Nil |
There was a problem hiding this comment.
Should not be needed, the empty value for a uuid.UUID is uuid.Nil already.
server/db.go
Outdated
| var pgErr *pgconn.PgError | ||
| if errors.As(err, &pgErr) && pgErr.Code == pgerrcode.SerializationFailure { | ||
| // A recognised error type that can be retried. | ||
| goto retry |
There was a problem hiding this comment.
Not a fan of the goto. Can we rewrite this more neatly, and also implement the max retries we've done elsewhere already?
redbaron
force-pushed
the
storage-read-multi-args
branch
from
d0b8532
to
9ec9ec6
Compare
When selecting variable number of objects it's better to keep number of SQL query arguments constant, otherwise query statistics explode, because from PostgreSQL perspective query with different number of arguments is a distinct query.
redbaron
force-pushed
the
storage-read-multi-args
branch
from
9ec9ec6
to
991bfa2
Compare
zyro
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When selecting variable number of objects it's better to keep number of SQL query arguments constant, otherwise query statistics explode, because from PostgreSQL perspective query with different number of arguments is a distinct query.