Upgrade docker compose crdb to v23.1 #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sesposito My vote is that we lift the minimum required CRDB version rather than provide a workaround for an older CRDB release. It's a good time to lift the minimum version required as we move to PGX v5 as well. |
|
I vote for this over #1066 |
|
I agree, this is the correct solution. Let's merge this and close the others. |
zyro
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reworked queries introduced in #1044 are incompatible with some older versions of crdb due to this bug: cockroachdb/cockroach#60907 that has been fixed.
Upgrading crdb resolves this.
Alternatively, we'd have to merge #1066 to keep backwards compatibility.