Improve build cache expiration logic #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshwlewis
force-pushed
the
jwl/expire-cache-arch
branch
from
92b9281
to
87f2b17
Compare
Signed-off-by: Josh W Lewis <josh.lewis@salesforce.com>
joshwlewis
force-pushed
the
jwl/expire-cache-arch
branch
from
87f2b17
to
7885ccf
Compare
edmorley
approved these changes
May 17, 2024
This was referenced Jun 4, 2024
Merged
heroku-linguist bot
added a commit
to heroku/cnb-builder-images
that referenced
this pull request
Jun 4, 2024
## heroku/go ### Added - Added go1.21.11 (linux-amd64), go1.21.11 (linux-arm64). - Added go1.22.4 (linux-arm64), go1.22.4 (linux-amd64). ### Changed - The build cache is now invalidated when the target distribution changes. ([#267](heroku/buildpacks-go#267)) - The build cache is no longer invalidated on minor go version changes. ([#267](heroku/buildpacks-go#267)) Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build cache (which includes intermediate compilation artifacts) should be invalidated when the target arch, distro, or distro version changes. These assets are unlikely to be valid after a major change to the OS, especially if any C bindings are involved. We were already supporting expiration based on architecture changes, but not distro details.
Conversely, the build cache artifacts may be valid after a minor go version change (patch level change in semver parlance). We were previously expiring these assets on any go version change, which meant frequent, perhaps unnecessary invalidation.
This PR introduces build cache invalidation based on distro changes, and prevents build cache invalidation for minor go version changes.