Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix spelling #2694

Merged
merged 2 commits into from
Mar 7, 2024
Merged

chore: fix spelling #2694

merged 2 commits into from
Mar 7, 2024

Conversation

eablack
Copy link
Contributor

@eablack eablack commented Mar 7, 2024 •
edited
Loading

Description

Recreates #2073

Testing

No functional changes anticipated aside from some spelling corrections in command descriptions.

@eablack eablack self-assigned this Mar 7, 2024
@eablack eablack mentioned this pull request Mar 7, 2024
Closed
sbosio
sbosio approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@sbosio sbosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Some of them were imperceptible.

@eablack eablack marked this pull request as ready for review March 7, 2024 22:34
@eablack eablack requested a review from a team as a code owner March 7, 2024 22:34
@eablack
Copy link
Contributor Author

eablack commented Mar 7, 2024

Thanks @sbosio! Credit goes to @jsoref. We should talk about adopting a spellchecker in our dev cycle (perhaps just the github action used in the original PR).

@eablack eablack merged commit 3c74d2a into main Mar 7, 2024
8 checks passed
@eablack eablack deleted the eb/fix-spelling branch March 7, 2024 22:38
@jsoref jsoref mentioned this pull request Mar 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbosio sbosio sbosio approved these changes

Assignees

@eablack eablack

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eablack @sbosio