Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ps): update larger dyno checking #2741

Merged
merged 4 commits into from
Mar 22, 2024
Merged

fix(ps): update larger dyno checking #2741

merged 4 commits into from
Mar 22, 2024

Conversation

zwhitfield3
Copy link
Contributor

Description

We moved the dyno checking in both ps:type and ps:scale downstream in the parse() function to account for a missed edge case during testing.

@zwhitfield3 zwhitfield3 marked this pull request as ready for review March 22, 2024 21:01
@zwhitfield3 zwhitfield3 requested a review from a team as a code owner March 22, 2024 21:01
@zwhitfield3 zwhitfield3 force-pushed the zw/larger-dyno-size-update-v2 branch from 3ecfdae to b6d9eb3 Compare March 22, 2024 21:14
sbosio
sbosio approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@sbosio sbosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zwhitfield3 zwhitfield3 merged commit 853b94f into main Mar 22, 2024
8 checks passed
@zwhitfield3 zwhitfield3 deleted the zw/larger-dyno-size-update-v2 branch March 22, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mars mars mars left review comments

@sbosio sbosio sbosio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zwhitfield3 @mars @sbosio