Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(auth): update warning message for auth:token #2750

Merged
merged 8 commits into from Apr 9, 2024
Merged

chore(auth): update warning message for auth:token #2750

merged 8 commits into from Apr 9, 2024

Conversation

zwhitfield3
Copy link
Contributor

Description

Work Item

This PR updates the warning message for the auth:token command according to userpass.

didgeoridoo
didgeoridoo approved these changes Mar 27, 2024
View reviewed changes
Copy link

@didgeoridoo didgeoridoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@zwhitfield3 zwhitfield3 marked this pull request as ready for review April 8, 2024 17:16
@zwhitfield3 zwhitfield3 requested a review from a team as a code owner April 8, 2024 17:16
sbosio
sbosio approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@sbosio sbosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor suggestion, but it looks ok so I'm approving.

@zwhitfield3 zwhitfield3 merged commit 4ddead4 into main Apr 9, 2024
8 checks passed
@zwhitfield3 zwhitfield3 deleted the zw/token-warn-update branch April 9, 2024 20:13
@kdreyeroren
Copy link

@zwhitfield3 This will be OK for the current iteration of V2 tokens; however, when this feature goes GA, we'll have to do this check in another way (i.e., we'd prefer if you could check using the userpass, rather than the email address, though I think that would be an additional layer of complexity here).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbosio sbosio sbosio approved these changes

@didgeoridoo didgeoridoo didgeoridoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zwhitfield3 @kdreyeroren @sbosio @didgeoridoo