Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a method to add env var to default truststore #10

Merged
merged 1 commit into from
Apr 18, 2018
Merged

Added a method to add env var to default truststore #10

merged 1 commit into from
Apr 18, 2018

Conversation

jkutner
Copy link
Contributor

@jkutner jkutner commented Apr 16, 2018 •
edited
Loading

The new method, addToDefaultTrustStore(String), adds a cert to the default truststore in the JVM. For example:

EnvKeyStore uberTruststore = EnvKeyStore.addToDefaultTrustStore(CERT);

Fixes #9

@jkutner jkutner mentioned this pull request Apr 16, 2018
Closed
holtonma
holtonma approved these changes Apr 18, 2018
View reviewed changes
Copy link

@holtonma holtonma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, @jkutner

Once you cut a release, we can pull this into our code and test out addToDefaultTrustStore(). (might be a week or two, to get out of our release freeze period)

@jkutner jkutner merged commit 74144c1 into master Apr 18, 2018
@jkutner jkutner deleted the add-to-truststore branch April 18, 2018 22:53
@jkutner
Copy link
Contributor Author

jkutner commented Apr 18, 2018

This should be available in 1.0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holtonma holtonma holtonma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkutner @holtonma