Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding start timeout parameter #549

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

charlyhue
Copy link

php-fpm take more than 2500 ms to start when Datadog appsec is enabled. This change add an optional parameter to configure this timeout.

@charlyhue charlyhue requested a review from a team as a code owner March 16, 2022 15:57
Copy link
Contributor

@dzuelke dzuelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please change the timeout default value to 2500, do an arithmetic operation to divide by 100, and adjust the help output to say -t <timeout> Startup timeout for launched processes (in ms), also mentioning the default value? Providing the timeout as a count is pretty unintuitive.

@dzuelke
Copy link
Contributor

dzuelke commented Feb 14, 2024

Bump?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants