Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update heroku-php-nginx for CGroupsv2 #690

Closed
wants to merge 2 commits into from
Closed

Conversation

usiegj00
Copy link

@usiegj00 usiegj00 commented Feb 7, 2024

This buildpack fails on modern OCI runtimes with cgroupsv2.

@usiegj00 usiegj00 requested a review from a team as a code owner February 7, 2024 08:32
@edmorley edmorley requested review from dzuelke and removed request for a team February 7, 2024 08:45
@bauerpl
Copy link

bauerpl commented Feb 12, 2024

@dzuelke -It appears that all tests have failed due to a 401 Unauthorized error, likely due to missing or incorrect HEROKU_API_KEY and HEROKU_APP_NAME config variables. Could you please verify if the secrets are set correctly? Your help would be really appreciated.

@dzuelke dzuelke self-assigned this Feb 14, 2024
@dzuelke
Copy link
Contributor

dzuelke commented Feb 14, 2024

@dzuelke -It appears that all tests have failed due to a 401 Unauthorized error, likely due to missing or incorrect HEROKU_API_KEY and HEROKU_APP_NAME config variables. Could you please verify if the secrets are set correctly? Your help would be really appreciated.

Yes; the necessary GHA secrets aren't available for forks ;)

General feedback on this PR: I have been working on the same thing, so we can make it a race to see who's done sooner ;) But if you have time immediately and can finish it quickly...

  1. please use a list of possible locations to read from and loop over them... the current approach is pretty crude
  2. there need to be additional locations that get checked, since the current process may be in a different cgroup hierarchy
  3. bin/heroku-php-apache2 needs exactly the same changes
  4. ditto for bin/test
  5. ditto for the profile.d script generated in support/build/composer
  6. ditto for the profile.d script generated in support/build/php

@dzuelke
Copy link
Contributor

dzuelke commented Feb 20, 2024

Closing in favor of tracking issue #699

@dzuelke dzuelke closed this Feb 20, 2024
@edmorley edmorley removed the request for review from dzuelke February 20, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants