Unit testing and minor buildpack tweaks #4

naaman · 2012-01-20T05:14:48Z

Basic test coverage for the play buildpack
Some additional tweaks were made to the compile and detect scripts for portability
Note: this is using a workaround where we host full copies of the play framework in a new s3 bucket (heroku-jvm-buildpack-play-test). We need this for testing purposes and the .zip files hosted on the play framework site cannot be unzipped in a dyno -- we need gzip formatted archives. The current hosted versions of the framework are not full copies and can't be used either (e.g. play new doesn't work).

* Added test scripts for each buildpack phase * Testing done for detect and release :easy:

…nor case, the directory might exist, but be empty. This ensures the actual executable is present. * Added caching test.

…error.

…yntax error on a dyno.

* Test versioning -- upgrades, invalid versions, unsupported versions

* Test build cleanup

…n a dyno. As a result, we need to zip them up and host them somewhere (i.e. S3).

ryanbrainard · 2012-01-20T18:29:43Z

test/compile_test.sh

+
+. ${BUILDPACK_TEST_RUNNER_HOME}/lib/test_utils.sh
+
+# test modules and ivy deps from build time are removed and not included in the slug


what is this comment?

ryanbrainard · 2012-01-20T19:10:55Z

genernal nit picks:

use detect, compile, release instead of manually capturing
assertion message consistency
use assertFile(Not)Contains instead of assert(Not)Contains. might even consider creating new assertCaptured function so we don't have to repeat ${STD_OUT} everywhere.

* Cleanup assertions to use new utility assertions * Fix upgrade logic so that it removes the old play framework when upgrading versions

naaman · 2012-01-20T22:09:32Z

Fixed all your nitpicks. Merge it!

Unit testing and minor buildpack tweaks

Naaman Newbold added 13 commits January 17, 2012 16:19

* Fix detect script to work on mac, for local development

0e29eb9

* Added test scripts for each buildpack phase * Testing done for detect and release :easy:

Using /bin/sh as executable to work with heroku run.

ae6aa56

* Made play detection detect the actual play executable. In a very mi…

9a2ecac

…nor case, the directory might exist, but be empty. This ensures the actual executable is present. * Added caching test.

Fixing redirection to dev/null

7bc5390

Attempt at fixing redirect error on dyno.

f8b190d

Removing multiline assertions to see if that fixes the redirect problem.

9c7e3fe

Found extraneous curly brace, which is probably causing the redirect …

d4b4d13

…error.

Found extraneous curly brace, which is probably causing the redirect …

2946258

…error.

Trying to use /usr/bin/env bash instead of /bin/sh to eliminate the s…

f4e6536

…yntax error on a dyno.

Remove mock play app function.

3a89ce8

* Test caching -- ensure ivy and play dirs are copied correctly

ff41d05

* Test versioning -- upgrades, invalid versions, unsupported versions

* Test build phases

ba36626

* Test build cleanup

Using S3 for full versions of play. Zip archives cannot be unzipped o…

9d8c7c5

…n a dyno. As a result, we need to zip them up and host them somewhere (i.e. S3).

ryanbrainard reviewed Jan 20, 2012
View reviewed changes

* Cleanup test messaging consistency

5e8e2bc

* Cleanup assertions to use new utility assertions * Fix upgrade logic so that it removes the old play framework when upgrading versions

Naaman Newbold added 3 commits January 20, 2012 16:45

Rolling back upgrade changes. The play removal was already happening.

8fda4d7

Using compile instead of capture

b087303

Removing unnecessary vars in release test

cff1db4

ryanbrainard added a commit that referenced this pull request Jan 21, 2012

Merge pull request #4 from naamannewbold/master

0dde325

Unit testing and minor buildpack tweaks

ryanbrainard merged commit 0dde325 into heroku:master Jan 21, 2012

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unit testing and minor buildpack tweaks #4

Unit testing and minor buildpack tweaks #4

naaman commented Jan 20, 2012

ryanbrainard Jan 20, 2012

ryanbrainard commented Jan 20, 2012

naaman commented Jan 20, 2012


		. ${BUILDPACK_TEST_RUNNER_HOME}/lib/test_utils.sh

		# test modules and ivy deps from build time are removed and not included in the slug

Unit testing and minor buildpack tweaks #4

Unit testing and minor buildpack tweaks #4

Conversation

naaman commented Jan 20, 2012

ryanbrainard Jan 20, 2012

Choose a reason for hiding this comment

ryanbrainard commented Jan 20, 2012

naaman commented Jan 20, 2012