Skip to content

Commit

Permalink
Update test assertions after changes to the getting started guide (#1450
Browse files Browse the repository at this point in the history
)

The recent changes to the Python getting started guide mean the
existing log output assertions need adjusting, since the tests are now
failing:
https://github.com/heroku/heroku-buildpack-python/actions/runs/4869442189/jobs/9038239643#step:5:375
heroku/python-getting-started@7d2f6a1...c99a168

The `getting_started_spec.rb` test has been removed rather than
fixing it, since it was a duplicate of the tests in `django_spec.rb`.

GUS-W-13152716.
  • Loading branch information
edmorley committed May 22, 2023
1 parent 892d5a0 commit 076cdd2
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 20 deletions.
11 changes: 6 additions & 5 deletions spec/hatchet/django_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
app.deploy do |app|
expect(clean_output(app.output)).to match(Regexp.new(<<~REGEX))
remote: -----> \\$ python manage.py collectstatic --noinput
remote: \\d+ static files copied to '/tmp/build_.*/staticfiles', \\d+ post-processed.
remote: WARNING:root:No DATABASE_URL environment variable set, and so no databases setup
remote: \\d+ static files? copied to '/tmp/build_.*/staticfiles', \\d+ post-processed.
REGEX
end
end
Expand All @@ -36,7 +37,7 @@
it 'skips collectstatic' do
app.deploy do |app|
expect(app.output).to include('Skipping Django collectstatic since the env var DISABLE_COLLECTSTATIC is set.')
expect(app.output).not_to include('static files copied')
expect(app.output).not_to include('manage.py collectstatic')
end
end
end
Expand All @@ -46,7 +47,7 @@

it 'still runs collectstatic' do
app.deploy do |app|
expect(app.output).to include('static files copied')
expect(app.output).to include('manage.py collectstatic')
end
end
end
Expand All @@ -56,7 +57,7 @@

it 'still runs collectstatic' do
app.deploy do |app|
expect(app.output).to include('static files copied')
expect(app.output).to include('manage.py collectstatic')
end
end
end
Expand All @@ -70,7 +71,7 @@
remote: -----> Skipping Django collectstatic since the file '.heroku/collectstatic_disabled' exists.
remote: ! This approach is deprecated, please set the env var DISABLE_COLLECTSTATIC=1 instead.
OUTPUT
expect(app.output).not_to include('static files copied')
expect(app.output).not_to include('manage.py collectstatic')
end
end
end
Expand Down
15 changes: 0 additions & 15 deletions spec/hatchet/getting_started_spec.rb

This file was deleted.

0 comments on commit 076cdd2

Please sign in to comment.