Update test assertions after changes to the getting started guide #1450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent changes to the Python getting started guide mean the existing log output assertions need adjusting, since the tests are now failing: https://github.com/heroku/heroku-buildpack-python/actions/runs/4869442189/jobs/9038239643#step:5:375 The `getting_started_spec.rb` test has been removed rather than fixing it, since it was a duplicate of the tests in `django_spec.rb`. GUS-W-13152716.
edmorley
force-pushed
the
fix-getting-started-test
branch
from
b305eee
to
f6fa965
Compare
joshwlewis
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent changes to the Python getting started guide mean the existing log output assertions need adjusting, since the tests are now failing:
https://github.com/heroku/heroku-buildpack-python/actions/runs/4869442189/jobs/9038239643#step:5:375
heroku/python-getting-started@7d2f6a1...c99a168
The
getting_started_spec.rbtest has been removed rather than fixing it, since it was a duplicate of the tests indjango_spec.rb.GUS-W-13152716.