Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not properly clearing cache between builds #295

Closed
schneems opened this issue Jul 30, 2014 · 1 comment
Closed

Not properly clearing cache between builds #295

schneems opened this issue Jul 30, 2014 · 1 comment

Comments

@schneems
Copy link
Contributor

Related issue: https://support.heroku.com/tickets/127432?col=0&page=1
@schneems
Copy link
Contributor Author

schneems commented Aug 4, 2014

@hone found the problem. On this line https://github.com/heroku/heroku-buildpack-ruby/blob/master/lib/language_pack/ruby.rb#L775

After we migrate the cache:

cache.exists?(bundler_cache)

Will be false because it's checking in

  def bundler_cache
    "vendor/bundle"
  end

Which is empty because it got migrated

hone added a commit that referenced this issue Aug 4, 2014
@hone
Merge pull request #298 from heroku/schneems/cache-fuuuu-ness
dd39a9d 
[close #295] correctly clear cache after version change
lxfontes added a commit to lxfontes/heroku-buildpack-ruby that referenced this issue Aug 18, 2014
@lxfontes
Merge remote-tracking branch 'heroku/master'
bcf2687 
* heroku/master: (88 commits)
  bump to v126
  update changelog
  [close heroku#295] correctly clear cache after version change
  ensure message is a string before splitting
  in cedar-14, we need to install a java runtime for yui-compressor
  bump to v125
  update changelog
  bump to node 0.10.30 for http://blog.nodejs.org/2014/07/31/v8-memory-corruption-stack-overflow/
  bump to v124
  update changelog
  cycle travis password
  rev hatchet app limit
  move fetchers into NodeInstaller class, node-0.4.7.tgz is cedar specific
  extract logic into NodeInstaller class, add cedar support back
  install node 0.10.29 for cedar-14
  extract individual files from the fetcher
  use the vendored java not the stack image one
  bump to v123
  update changelog
  don't load the cache if we just converted the stack
  ...

Conflicts:
	lib/language_pack/ruby.rb
charlietran added a commit to vhx/heroku-buildpack that referenced this issue Sep 3, 2014
@charlietran
Merge branch 'master' of https://github.com/heroku/heroku-buildpack-ruby
9e58d81 


# By Terence Lee (35) and schneems (25)
# Via Terence Lee (11) and Richard Schneeman (6)
* 'master' of https://github.com/heroku/heroku-buildpack-ruby: (60 commits)
  bump to v126
  update changelog
  [close heroku#295] correctly clear cache after version change
  ensure message is a string before splitting
  in cedar-14, we need to install a java runtime for yui-compressor
  bump to v125
  update changelog
  bump to node 0.10.30 for http://blog.nodejs.org/2014/07/31/v8-memory-corruption-stack-overflow/
  bump to v124
  update changelog
  cycle travis password
  rev hatchet app limit
  move fetchers into NodeInstaller class, node-0.4.7.tgz is cedar specific
  extract logic into NodeInstaller class, add cedar support back
  install node 0.10.29 for cedar-14
  extract individual files from the fetcher
  use the vendored java not the stack image one
  bump to v123
  update changelog
  don't load the cache if we just converted the stack
  ...
cbartlett added a commit to cbartlett/heroku-buildpack-ruby-tpope that referenced this issue Sep 24, 2014
@cbartlett
Merge remote-tracking branch 'heroku/master'
093cfd8 
* heroku/master: (83 commits)
  bump to v127
  update changelog
  rbx now supports cedar and cedar-14
  bump to v126
  update changelog
  [close heroku#295] correctly clear cache after version change
  ensure message is a string before splitting
  in cedar-14, we need to install a java runtime for yui-compressor
  bump to v125
  update changelog
  bump to node 0.10.30 for http://blog.nodejs.org/2014/07/31/v8-memory-corruption-stack-overflow/
  bump to v124
  update changelog
  cycle travis password
  rev hatchet app limit
  move fetchers into NodeInstaller class, node-0.4.7.tgz is cedar specific
  extract logic into NodeInstaller class, add cedar support back
  install node 0.10.29 for cedar-14
  extract individual files from the fetcher
  use the vendored java not the stack image one
  ...
outoftime added a commit to Genius/heroku-buildpack-ruby that referenced this issue Oct 20, 2014
@outoftime
Merge branch 'master' of git://github.com/heroku/heroku-buildpack-rub…
98c8f6f 
…y into custom-vendor-url

* 'master' of git://github.com/heroku/heroku-buildpack-ruby: (42 commits)
  bump to v127
  update changelog
  rbx now supports cedar and cedar-14
  corrected removal of travis key
  bump to v126
  update changelog
  [close heroku#295] correctly clear cache after version change
  ensure message is a string before splitting
  in cedar-14, we need to install a java runtime for yui-compressor
  bump to v125
  update changelog
  bump to node 0.10.30 for http://blog.nodejs.org/2014/07/31/v8-memory-corruption-stack-overflow/
  bump to v124
  update changelog
  cycle travis password
  rev hatchet app limit
  move fetchers into NodeInstaller class, node-0.4.7.tgz is cedar specific
  extract logic into NodeInstaller class, add cedar support back
  install node 0.10.29 for cedar-14
  extract individual files from the fetcher
  ...

Conflicts:
	lib/language_pack/base.rb
sbounmy added a commit to sbounmy/heroku-buildpack-ruby that referenced this issue Dec 14, 2014
@sbounmy
Merge branch 'master' of github.com:heroku/heroku-buildpack-ruby
51906f4 
* 'master' of github.com:heroku/heroku-buildpack-ruby: (53 commits)
  v129
  bump to v129
  Ensure cache doesn't grow unbounded
  Fix tests to work on cedar-14 by default
  v128 changelog
  bump to v128
  travis, again
  Keep same error interface
  better cedar-14 ruby install error message
  bump to v127
  update changelog
  rbx now supports cedar and cedar-14
  corrected removal of travis key
  bump to v126
  update changelog
  [close heroku#295] correctly clear cache after version change
  ensure message is a string before splitting
  in cedar-14, we need to install a java runtime for yui-compressor
  bump to v125
  update changelog
  ...

Conflicts:
	bin/compile
	lib/language_pack/base.rb
tpope added a commit to tpope/heroku-buildpack-ruby-tpope that referenced this issue Dec 21, 2014
@tpope
Merge remote-tracking branch 'heroku/master'
37e06fb 
* heroku/master: (93 commits)
  v129
  bump to v129
  Ensure cache doesn't grow unbounded
  Fix tests to work on cedar-14 by default
  v128 changelog
  bump to v128
  travis, again
  Keep same error interface
  better cedar-14 ruby install error message
  bump to v127
  update changelog
  rbx now supports cedar and cedar-14
  corrected removal of travis key
  bump to v126
  update changelog
  [close heroku#295] correctly clear cache after version change
  ensure message is a string before splitting
  in cedar-14, we need to install a java runtime for yui-compressor
  bump to v125
  update changelog
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@schneems