Close #783 Warn on action_dispatch.x_sendfile_header
#795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneems
force-pushed
the
schneems/x-sendfile
branch
8 times, most recently
from
43b484c
to
7c9a812
Compare
When serving files if the `action_dispatch.x_sendfile_header` is set then it is essentially saying “i don’t need to serve this asset, let nginx or apache do it for me”. The problem is…on heroku most people aren’t using apache or nginx so this causes a silent failure that is hard to debug. This warning will hopefully help people identify their mistake earlier.
schneems
force-pushed
the
schneems/x-sendfile
branch
from
7c9a812
to
6429f7b
Compare
jkutner
approved these changes
Aug 20, 2018
calebhearth
approved these changes
Aug 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When serving files if the
action_dispatch.x_sendfile_headeris set then it is essentially saying “i don’t need to serve this asset, let nginx or apache do it for me”. The problem is…on heroku most people aren’t using apache or nginx so this causes a silent failure that is hard to debug.This warning will hopefully help people identify their mistake earlier.