fix: make no-kafka optional dependency (#183)

heroku · Mar 5, 2018 · 5d97654 · 5d97654
1 parent d66a2aa
commit 5d97654
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/commands/topics_tail.js b/commands/topics_tail.js
@@ -2,7 +2,6 @@
 
 const cli = require('heroku-cli-util')
 const co = require('co')
-const kafka = require('no-kafka')
 
 const debug = require('../lib/debug')
 const clusterConfig = require('../lib/shared').clusterConfig
@@ -15,6 +14,7 @@ const IDLE_TIMEOUT = 1000
 const MAX_LENGTH = 80
 
 function * tail (context, heroku) {
+  const kafka = require('no-kafka')
   yield withCluster(heroku, context.app, context.args.CLUSTER, function * (addon) {
     if (isPrivate(addon)) {
       throw new Error('`kafka:topics:tail` is not available in Heroku Private Spaces')

diff --git a/commands/topics_write.js b/commands/topics_write.js
@@ -2,7 +2,6 @@
 
 const cli = require('heroku-cli-util')
 const co = require('co')
-const kafka = require('no-kafka')
 
 const debug = require('../lib/debug')
 const clusterConfig = require('../lib/shared').clusterConfig
@@ -14,6 +13,7 @@ const CLIENT_ID = 'heroku-write-producer'
 const IDLE_TIMEOUT = 1000
 
 function * write (context, heroku) {
+  const kafka = require('no-kafka')
   yield withCluster(heroku, context.app, context.args.CLUSTER, function * (addon) {
     if (isPrivate(addon)) {
       cli.exit(1, '`kafka:topics:write` is not available in Heroku Private Spaces')

diff --git a/package.json b/package.json
@@ -14,9 +14,11 @@
     "heroku-cli-util": "6.1.17",
     "humanize-plus": "^1.8.2",
     "lodash.uniqby": "4.7.0",
-    "no-kafka": "github:hunterloftis/kafka",
     "node-spinner": "0.0.4"
   },
+  "optionalDependencies": {
+    "no-kafka": "github:hunterloftis/kafka"
+  },
   "devDependencies": {
     "chai": "^3.5.0",
     "chai-as-promised": "^5.3.0",