add topic prefix support #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some users may have prefixed topic names. This commit adds support for prepending the prefix to the topic name when producing and consuming. Additionally, the `no-kafka` dependency is updated and locked to 3.1.0.
|
@thody yeah, +1. And if we are moving to mainline |
|
@uhoh-itsmaciek @thody We figured out the no-kafka issue on my laptop. We need to use node v6 (I was using v7). Is this 👍 to merge now? |
|
Ok, great. Is adding for tests reasonable? I don't recall how hairy the existing |
msakrejda
reviewed
Jan 19, 2017
| clientCert: config.clientCert, | ||
| clientCertKey: config.clientCertKey | ||
| cert: config.clientCert, | ||
| key: config.clientCertKey |
There was a problem hiding this comment.
Is this change (and the same thing in the other file) still necessary? I thought this was an artifact of moving to the mainline no-kafka?
There was a problem hiding this comment.
Yes, you are correct. I will fix it soon.
|
@uhoh-itsmaciek tests added 💙 |
msakrejda
reviewed
Jan 19, 2017
| @@ -31,6 +31,7 @@ $ heroku plugins:install heroku-kafka | |||
|
|
|||
| For normal development, the initial setup is: | |||
| ``` sh-session | |||
| # ensure node 6.x is installed | |||
|
🥇 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users may have prefixed topic names. This commit adds support for prepending the prefix to the topic name when producing and consuming.
Additionally, the
no-kafkadependency is updated and locked to 3.1.0.