Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove jmx command #139

Merged
merged 1 commit into from Jan 25, 2017
Merged

remove jmx command #139

merged 1 commit into from Jan 25, 2017

Conversation

jdowning
Copy link
Member

@jdowning jdowning commented Jan 24, 2017

The corresponding endpoint does not exist.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 87.222% when pulling d075030 on remove-jmx into cc565a4 on master.

@msakrejda
Copy link
Contributor

The command is hidden. Is the endpoint never going to exist? It was originally planned to exist shortly after we added the command.

@idan
Copy link
Contributor

idan commented Jan 24, 2017

@thody to follow up with Justin about what this means

@thody
Copy link

thody commented Jan 25, 2017

+1

@thody
Copy link

thody commented Jan 25, 2017

@heroku/dod-ux for context, this command was intended to toggle JMX access after provision time, but it was never implemented API-side (casualty of some pre-GA scope cutting). There's little likelihood that we'll implement this, so just cleaning up dead code here.

@msakrejda
Copy link
Contributor

Cool, thanks for following up.

@jdowning jdowning merged commit 2613681 into master Jan 25, 2017
@jdowning jdowning deleted the remove-jmx branch January 25, 2017 16:58
@idan idan removed the Doing label Jan 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants