Fix kafka:tail for v6 compatibility #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msakrejda
force-pushed
the
v6-compatibility
branch
from
f474c59
to
a465f58
Compare
msakrejda
force-pushed
the
v6-compatibility
branch
from
a465f58
to
b118f58
Compare
This lets us be compatible with v6 CLI. Also change some exits to throw instead and let the CLI handle errors, and update tests to work with the new mechanism. The changes require us to mock out `process` in tests, so we export it from the command and let our tests override it.
msakrejda
force-pushed
the
v6-compatibility
branch
from
b118f58
to
0fd7760
Compare
jdx
approved these changes
May 31, 2017
msakrejda
commented
May 31, 2017
| @@ -106,59 +121,65 @@ describe('kafka:topics:tail', () => { | |||
| consumer.subscribe = (topic, callback) => { | |||
| callback([ | |||
| { offset: 1, message: { value: Buffer.from('hello') } }, | |||
| { offset: 2, message: { value: Buffer.from('world') } } | |||
| { offset: 2, message: { value: Buffer.from('world') } }, | |||
| { offset: 3, message: { value: null } } | |||
There was a problem hiding this comment.
I also added a null-valued message since that goes through a slightly different code path.
|
/cc @ahamidi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.