Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

never run aggressive #18

Closed
wants to merge 1 commit into from
Closed

never run aggressive #18

wants to merge 1 commit into from

Conversation

wuputah
Copy link
Contributor

@wuputah wuputah commented Dec 17, 2013

aggressive is a very intensive and most likely unneeded task that is
unlikely to finish in a dyno. for more on aggressive, see:
http://metalinguist.wordpress.com/2007/12/06/the-woes-of-git-gc-aggressive-and-how-git-deltas-work/

aggressive is a very intensive and most likely unneeded task that is
unlikely to finish in a dyno. for more on aggressive, see:
http://metalinguist.wordpress.com/2007/12/06/the-woes-of-git-gc-aggressive-and-how-git-deltas-work/
@tt
Copy link
Member

tt commented Dec 17, 2013

Should we perhaps leave it as a flag? Perhaps the arguments to heroku repo:gc would just be passed to git gc. Then you'd also be able to set --prune, if you wanted to.

@wuputah
Copy link
Contributor Author

wuputah commented Dec 18, 2013

Perhaps, but I don't know how to do that. In any case, I think the most sane default is definitely not --aggressive.

@lstoll
Copy link
Contributor

lstoll commented Dec 18, 2013

I'd definitely say drop the --agressive by default. I originally did this for a handful of specific people who were doing very Dumb Things with their repos, who needed a crazy level of fixing. The general case should be a normal GC. I do like the idea of just passing through args to the git gc command, sounds neat and way more flexible.

@wuputah wuputah closed this Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants