Improve Env::get, add Env::get_string_lossy
#565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Malax
force-pushed
the
malax/env-changes
branch
3 times, most recently
from
5c62ba6
to
1632840
Compare
Malax
force-pushed
the
malax/env-changes
branch
from
1632840
to
ce2b0cb
Compare
edmorley
approved these changes
Apr 26, 2023
colincasey
added a commit
that referenced
this pull request
Jun 12, 2023
* main: Update fastrand requirement from 1.8.0 to 2.0.0 (#573) Fix lint failures with Rust 1.70 (#574) Bump Swatinem/rust-cache from 2.3.0 to 2.4.0 (#572) Bump Swatinem/rust-cache from 2.2.1 to 2.3.0 (#571) Bump buildpacks/github-actions from 5.1.0 to 5.2.0 (#569) Prepare 0.12.0 release (#568) Support Buildpack API `0.9` (#567) Add Clone for Scope (#566) Improve Env::get, add Env::get_string_lossy (#565) Bump buildpacks/github-actions from 5.0.1 to 5.1.0 (#564)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Changed
Env::getnow returnsOption<&OsString>instead ofOption<OsString>. This is more in line with expectations users have when dealing with a collection type. This is a breaking change, compile errors can be fixed by adding aOption::clonedcall afterEnv::getto get the old behaviour. In some cases, cloning might not be necessary, slightly improving the code that usesEnv::get. (#565)Added
Env::get_string_lossyas a convenience method to work with environment variables directly. Getting a value out of anEnvand treating its contents as unicode is a common case. Using this new method can simplify buildpack code. (#565)Closes #74.