Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Buildpack API 0.9 #567

Merged
merged 4 commits into from
Apr 28, 2023
Merged

Support Buildpack API 0.9 #567

merged 4 commits into from
Apr 28, 2023

Conversation

Malax
Copy link
Member

@Malax Malax commented Apr 28, 2023

Updates libcnb.rs to target CNB spec 0.9. The only changes that affect libcnb.rs are the removal of the direct field for processes and command now being a list of values instead of a single value. The behaviour of the args field changed slightly, but that change has no impact on actual libcnb.rs code. I added a note about that change to the CHANGELOG with a link to the upstream spec so migrating users are aware.

Relevant Documentation

Changelog

Changed

  • libcnb.rs now targets Buildpack API 0.9. Buildpacks need to upgrade the api key to 0.9 in their buildpack.toml. (#567)
    • Process no longer supports the direct flag. All processes are now direct. (#567)
    • Process::command has been changed to a sequence of values where the first one is the executable and any additional values are arguments to the executable. The already existing args field behaves slightly different now as its contents can now be overridden by the user. See the upstream CNB specification for details. (#567)

Closes #513, GUS-W-11902806, GUS-W-13118532

@Malax Malax changed the title Remove Process::direct, make Process::command a list Support Buildpack API 0.9 Apr 28, 2023
@Malax Malax added this to the Buildpack API 0.9 milestone Apr 28, 2023
@Malax Malax marked this pull request as ready for review April 28, 2023 10:25
@Malax Malax requested a review from a team as a code owner April 28, 2023 10:25
Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

README.md Show resolved Hide resolved
libcnb-data/src/launch.rs Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@Malax Malax merged commit 3ba0f1b into main Apr 28, 2023
4 checks passed
@Malax Malax deleted the malax/buildpack_api_0.9 branch April 28, 2023 11:30
colincasey added a commit that referenced this pull request Jun 12, 2023
* main:
  Update fastrand requirement from 1.8.0 to 2.0.0 (#573)
  Fix lint failures with Rust 1.70 (#574)
  Bump Swatinem/rust-cache from 2.3.0 to 2.4.0 (#572)
  Bump Swatinem/rust-cache from 2.2.1 to 2.3.0 (#571)
  Bump buildpacks/github-actions from 5.1.0 to 5.2.0 (#569)
  Prepare 0.12.0 release (#568)
  Support Buildpack API `0.9` (#567)
  Add Clone for Scope (#566)
  Improve Env::get, add Env::get_string_lossy (#565)
  Bump buildpacks/github-actions from 5.0.1 to 5.1.0 (#564)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Identify changes required to support Buildpack API 0.9
2 participants