Update platform API to current schema #56
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds APIs available as of 13 January 2017. Among other things, these include: • Teams (organizations) • Federated log-in and identity providers • App formations sets • Heroku SSL (SNI Endpoint) These APIs include a deprecated endpoint in `PlatformAPI::Source` which is imported as `create___deprecated`. While not an ideal name, this is at least callable, and it’s not going to be mistaken for either its non-deprecated replacement (which takes a different number of parameters) or anything else that’s currently recommended.
|
See also: interagent/heroics#78 (comment) (which thanks to schema fixes is probably not absolutely necessary, but would still be nice to have in some capacity). |
This was referenced Apr 12, 2017
|
I believe the newest release(s) included the new stuff, though we lost track of this PR along the way. Apologies for this lingering for so long. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds APIs available as of 13 January 2017. Among other things, these include:
I have no idea what the policy is for updating this gem, but since I need one of these APIs (SNI Endpoint), I thought it wouldn't hurt to send a pull request.
This is just a straight rebuild on the current
schema.json. I have two concerns about it:The schema appears to have changed many endpoints from using the spelling
addontoadd-on. This has caused widespread spelling changes fromAddontoAddOnand fromaddontoadd_on. While the new spellings are probably more readable, this will probably break a lot of existing code. Should we add in some sort of compatibility aliasing for the old names? I don't see any indication in the project that this is currently being done.The old
PlatformAPI::Source#createcall has been deprecated, which (thanks to a bit of patching by @naaman) turns it intocreate___deprecatedwith three underscores. While not an ideal name, this is at least callable, and it’s not going to be mistaken for either its non-deprecated replacement (which takes a different number of parameters, so mixing the two up will cause a runtime error) or anything else that’s currently recommended.