Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passthrough meta on all requests #42

Closed
ryanbrainard opened this issue Jan 19, 2016 · 1 comment
Closed

Passthrough meta on all requests #42

ryanbrainard opened this issue Jan 19, 2016 · 1 comment
Labels
discussion enhancement

Comments

@ryanbrainard
Copy link
Contributor

Currently, meta only works if value is also set (i.e. only for identity requests). I'm thinking that a better way would be for meta to work for URL-based requests too and for request and response to be merged into meta. This would allow applications to add arbitrary metadata to any request and make it accessible to the component. I don't have a great use case of that off hand, but I like that it makes identity requests more "normal." The downside I see that meta currently allows any data type, but if we go this route, it would have to be an object. Thoughts?
@ryanbrainard ryanbrainard mentioned this issue Jan 19, 2016
Merged
ryanbrainard added a commit that referenced this issue Jan 25, 2016
@ryanbrainard
Passthrough meta
185e9b7 
Allow clients to set the initial `meta` value on the request. This is primarily for transformations with identity requests, but this generalizes the pattern for all requests.

Delivers #42
@ryanbrainard ryanbrainard mentioned this issue Jan 25, 2016
Merged
@jsullivan
Copy link
Contributor

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jsullivan @ryanbrainard