Passthrough provided meta in identity requests #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -179,7 +179,7 @@ export default function connect(mapPropsToRequestsToProps, options = {}) { | |||
| const onRejection = this.createPromiseStateOnRejection(prop, mapping, startedAt) | |||
|
|
|||
| if (mapping.value) { | |||
| const meta = {} | |||
| const meta = mapping.meta || {} | |||
| this.setAtomicState(prop, startedAt, mapping, initPS(meta)) | |||
There was a problem hiding this comment.
I went ahead and made this set the provided meta on the pending PromiseState; however, this is different behavior from the value, which is not set until the PromiseState is fulfilled. I'm not super happy about this, but I think it is the most expected behavior. We can think about setting value up front, but then it's different from regular URL-based requests. Feedback welcome.
cc: @jsullivan @hburrows
|
Going to pull this in early for the beta, but please review async before this ships in 0.7.0 |
ryanbrainard
added a commit
that referenced
this pull request
Jan 19, 2016
Passthrough provided meta in identity requests
| @@ -26,7 +26,8 @@ Instead, it *returns* a new, connected component class, for you to use. | |||
| - `andThen(value, meta): { prop: request, ... }` *(Function)*: returns an object of request mappings to fetch after fulfillment of this request but does not replace this request. Takes the `value` and `meta` of this request as arguments. | |||
| - `andCatch(reason, meta): { prop: request, ... }` *(Function)*: returns an object of request mappings to fetch after rejection of this request but does not replace this request. Takes the `value` and `meta` of this request as arguments. | |||
| - `value` *(Any)*: Data to passthrough directly to `PromiseState` as an alternative to providing a URL. This is an advanced option used for static data and data transformations. | |||
|
|
|||
| - `meta` *(Any)*: Metadata to passthrough directly to `PromiseState`. This attribute is only recognized if `value` is also provided. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identity requests (i.e. requests with
value) should also supportmetato pass along to along in transformations; otherwise, this metadata gets lost and is not accessible by the component.