Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OverviewMap control #439

Open
dracic opened this issue Dec 19, 2015 · 3 comments
Open

OverviewMap control #439

dracic opened this issue Dec 19, 2015 · 3 comments

Comments

@dracic
Copy link
Contributor

dracic commented Dec 19, 2015

How about pulling this one for 1.0.6:

https://github.com/boundlessgeo/gxp/pull/117/files

@justb4
Copy link
Contributor

justb4 commented Dec 21, 2015

Very good idea! Overview Map is a desired feature in Heron:
#192. Problem is that GXP is
not eager to merge PRs (see list
https://github.com/boundlessgeo/gxp/pulls). That is why I have a
"shadow" GXP clone at https://github.com/justb4/gxp/ and try to PR to
GXP and merge. Not all are accepted. Don't know if I can forward pulls
to GXP master to my clone. I will see what to do.

On 19-12-15 23:16, dracic wrote:

How about pulling this one for 106:

https://githubcom/boundlessgeo/gxp/pull/117/files


Reply to this email directly or view it on GitHub
#439.

@dracic
Copy link
Contributor Author

dracic commented Dec 21, 2015

You could add one more remote tracking branch (the one from the PR is requested to gxp) to your local repo and merge (or cherry-pick) from there to your master, and then push to github. I think it is not necessary to have all Heron-specific changes added to upstream gxp.

@dracic
Copy link
Contributor Author

dracic commented Dec 21, 2015

So I pulled ovierviewmap control from @alrocar, and made PR for your version of gxp. Ready for testing....

justb4/gxp#4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants