Added heron_control, changed heron_description to use with uuv_simulator #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonybaltovski
requested changes
Jul 13, 2018
heron_description/CHANGELOG.rst
Outdated
| @@ -2,6 +2,10 @@ | |||
| Changelog for package heron_description | |||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | |||
|
|
|||
| 0.4.0 (2018-06-26) | |||
There was a problem hiding this comment.
Remove this, it get automatically generated when you use catkin_generate_changelog
heron_description/package.xml
Outdated
| @@ -1,7 +1,7 @@ | |||
| <?xml version="1.0"?> | |||
| <package> | |||
| <name>heron_description</name> | |||
| <version>0.3.0</version> | |||
| <version>0.4.0</version> | |||
There was a problem hiding this comment.
Revert, this is done using catkin_prepare_release
heron_description/urdf/sensors.xacro
Outdated
| <headingDrift>0.005</headingDrift> | ||
| <headingGaussianNoise>0.005</headingGaussianNoise> | ||
| </plugin> | ||
| </gazebo> |
heron_description/CMakeLists.txt
Outdated
| @@ -1,9 +1,13 @@ | |||
| cmake_minimum_required(VERSION 2.8.3) | |||
| project(heron_description) | |||
|
|
|||
| find_package(catkin REQUIRED COMPONENTS roslaunch) | |||
| find_package(catkin REQUIRED COMPONENTS | |||
| heron_msgs | |||
There was a problem hiding this comment.
Are heron_msgs needed? I don't see them used any where.
There was a problem hiding this comment.
Should I put "roslaunch" back in?
dniewinski
reviewed
Jul 13, 2018
heron_description/urdf/base.xacro
Outdated
| <!-- Collision geometry mesh, usually in STL format (it is recommended to keep | ||
| this geometry as simple as possible to improve the performance the physics engine | ||
| regarding the computation of collision forces) --> | ||
| <xacro:property name="collision_mesh_file" value="file://$(find heron_description)/meshes/heron_base.stl"/> |
There was a problem hiding this comment.
Does the simulator use the collision mesh to calculate buoyancy? If so, simplifying this mesh may go a long way for efficiency
tonybaltovski
approved these changes
Jul 16, 2018
|
@dniewinski any remaining concerns? |
|
LGTM |
|
@Nirzvi1 can you rebase? |
Deleted unnecessary comments Set frequency to 20Hz (the default update frequency of the um6 IMU).
* Added heron_control package * Deleted unnecessary comments from CMakeLists.txt * Updated robot_localization.yaml Deleted unnecessary comments Set frequency to 20Hz (the default update frequency of the um6 IMU). * Edited package.xml and moved heron_controller node from heron_control * Updated package.xml description
…arate sensor frame
added 9 commits
July 26, 2018 15:17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.