[Bug] Misleading title "Error" on popup notification when creating manual backup

[ErminMerdanovic]

Describe the bug

Misleading title "Error" on popup notification when creating manual backup.

Tell us how to replicate the bug

1. Click on the Backups tab.
2. Click on Create Backup.
3. Backup notification will popup with the Misleading title "Error"

Which components are affected by this bug?

Control Panel Web Interface

Hestia Control Panel Version

1.7.2

Operating system

Ubuntu 22.04

Log capture

No response

[AlecRust]

This is arguably a regression in #3401, as we now show titles in dialogs in more places.

Simply removing this line should revert this "global dialog" code to previous behaviour (no title):

hestiacp/web/templates/footer.php

Line 78 in f9c5198

title: '<?= _("Error") ?>',

Perhaps that's the best fix for now, this is included in #3461. But it will mean legitimate "error" dialogs don't show the "error" title.

As you can see from surrounding code such as if (!empty($_SESSION["error_msg"])): it looks like this "Task has been added to queue" message is being set to error_msg. So this code is currently specific to error messages, hence the "Error" title. Ideally a wider refactor would take place here, perhaps allowing these "global dialogs" to be of type notice or warn or error, instead of just error.