Replace jQuery UI dialogs with <dialog> #3401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lets merge it after 1.7.1 has been released... And not before I really don't want to introduce again a ton of bugs... |
AlecRust
force-pushed
the
native-dialogs
branch
3 times, most recently
from
30befb8
to
b69099b
Compare
AlecRust
force-pushed
the
native-dialogs
branch
from
b69099b
to
efa773c
Compare
jaapmarcus
approved these changes
Mar 27, 2023
ScIT-Raphael
added a commit
that referenced
this pull request
Mar 27, 2023
This reverts commit 9c2004f.
|
Missed the comment, revert merge PR has been placed. |
jaapmarcus
pushed a commit
that referenced
this pull request
Mar 27, 2023
jaapmarcus
pushed a commit
that referenced
this pull request
Mar 27, 2023
jaapmarcus
added a commit
that referenced
this pull request
Mar 29, 2023
* Replace jQuery UI dialogs with <dialog> (#3401) * Fix "active" state of RRD filters * Refine/ensure title * Refactor * Tidy * Use window.addEventListener('load') over window.onload * Refine * Fix input focus causing page zoom in Mobile Safari --------- Co-authored-by: Alec Rust <me@alecrust.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace jQuery UI dialogs with dialog element.
They look and behave very similarly. Modals can't be dragged about from the heading any more, which was weird.
This leaves only tabs we are using of jQuery UI, which can be removed separately.
Any manual testing of this branch would be appreciated.