feat: print out IPs after they were created (#590)

hetznercloud · Oct 26, 2023 · 0e0eaa8 · 0e0eaa8
1 parent 1c0e50a
commit 0e0eaa8
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 4 deletions.
diff --git a/internal/cmd/floatingip/create.go b/internal/cmd/floatingip/create.go
@@ -102,6 +102,11 @@ var CreateCmd = base.Cmd{
 
 		fmt.Printf("Floating IP %d created\n", result.FloatingIP.ID)
 
-		return changeProtection(ctx, client, waiter, result.FloatingIP, true, protectionOps)
+		if err := changeProtection(ctx, client, waiter, result.FloatingIP, true, protectionOps); err != nil {
+			return err
+		}
+
+		fmt.Printf("IP%s: %s\n", result.FloatingIP.Type[2:], result.FloatingIP.IP)
+		return nil
 	},
 }
diff --git a/internal/cmd/primaryip/create.go b/internal/cmd/primaryip/create.go
@@ -82,6 +82,7 @@ var CreateCmd = base.Cmd{
 			}
 		}
 
+		fmt.Printf("IP%s: %s\n", result.PrimaryIP.Type[2:], result.PrimaryIP.IP)
 		return nil
 	},
 }
diff --git a/internal/cmd/primaryip/create_test.go b/internal/cmd/primaryip/create_test.go
@@ -2,6 +2,7 @@ package primaryip
 
 import (
 	"context"
+	"net"
 	"testing"
 
 	"github.com/golang/mock/gomock"
@@ -29,8 +30,12 @@ func TestCreate(t *testing.T) {
 		).
 		Return(
 			&hcloud.PrimaryIPCreateResult{
-				PrimaryIP: &hcloud.PrimaryIP{ID: 1},
-				Action:    &hcloud.Action{ID: 321},
+				PrimaryIP: &hcloud.PrimaryIP{
+					ID:   1,
+					IP:   net.ParseIP("192.168.2.1"),
+					Type: hcloud.PrimaryIPTypeIPv4,
+				},
+				Action: &hcloud.Action{ID: 321},
 			},
 			&hcloud.Response{},
 			nil,
@@ -41,7 +46,9 @@ func TestCreate(t *testing.T) {
 
 	out, err := fx.Run(cmd, []string{"--name=my-ip", "--type=ipv4", "--datacenter=fsn1-dc14"})
 
-	expOut := "Primary IP 1 created\n"
+	expOut := `Primary IP 1 created
+IPv4: 192.168.2.1
+`
 
 	assert.NoError(t, err)
 	assert.Equal(t, expOut, out)