Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(firewall): port flag in add/delete-rule usage string #735

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

phm07
Copy link
Contributor

@phm07 phm07 commented Apr 19, 2024

See #733

@phm07 phm07 self-assigned this Apr 19, 2024
@phm07 phm07 requested a review from a team as a code owner April 19, 2024 10:38
@phm07 phm07 requested a review from jooola April 19, 2024 10:38
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.92%. Comparing base (da1b684) to head (29bad22).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #735   +/-   ##
=======================================
  Coverage   59.92%   59.92%           
=======================================
  Files         180      180           
  Lines        6511     6511           
=======================================
  Hits         3902     3902           
  Misses       1991     1991           
  Partials      618      618           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jooola jooola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change also have an influence on the behavior of the argument validation, correct? Should we scope this as feat or fix ?

I haven't tested it manually, but the code looks good.

@phm07
Copy link
Contributor Author

phm07 commented Apr 19, 2024

This change also have an influence on the behavior of the argument validation, correct? Should we scope this as feat or fix ?

I haven't tested it manually, but the code looks good.

No, the usage validation only checks positional arguments.

@phm07 phm07 merged commit 6fb4886 into main Apr 19, 2024
4 checks passed
@phm07 phm07 deleted the fix-firewall-rule-docs branch April 19, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants