feat(helm): remove "v" prefix from chart version (#565)

This makes sure that the chart version is fully semver compliant, as Helm expects.

Fixes #529

Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>
Co-authored-by: Julian Tölle <julian.toelle@hetzner-cloud.de>
Release-As: 1.19.0-rc.0

.goreleaser.yml

@@ -4,7 +4,7 @@
 before:
   hooks:
     - go mod tidy
-    - ./scripts/release-generate-deployment-yamls.sh {{ if not .IsSnapshot }}v{{ end }}{{ .Version }}
+    - ./scripts/release-generate-deployment-yamls.sh {{ .Version }}
 
 builds:
   - id: hcloud-cloud-controller-manager
@@ -59,6 +59,6 @@ publishers:
     ids: [""]
     checksum: true
 
-    cmd: ./scripts/publish-helm-chart.sh hcloud-cloud-controller-manager-{{ if not .IsSnapshot }}v{{ end }}{{ .Version }}.tgz
+    cmd: ./scripts/publish-helm-chart.sh hcloud-cloud-controller-manager-{{ .Version }}.tgz
     env:
       - CHART_REPO_REMOTE={{ .Env.CHART_REPO_REMOTE }}

chart/Chart.yaml

@@ -1,4 +1,4 @@
 apiVersion: v2
 name: hcloud-cloud-controller-manager
 type: application
-version: v1.18.0 # x-release-please-version
+version: 1.18.0 # x-release-please-version

chart/values.yaml

@@ -50,7 +50,7 @@ env:
 
 image:
   repository: hetznercloud/hcloud-cloud-controller-manager
-  tag: '{{ $.Chart.Version }}'
+  tag: 'v{{ $.Chart.Version }}'
 
 monitoring:
   # When enabled, the hccm Pod will serve metrics on port :8233