[bug] helm chart version is not semver compliant

[morremeyer]

As per https://helm.sh/docs/topics/charts/#the-chartyaml-file, a helm chart version has to be a SemVer 2.0.0 version.

The hcloud/hcloud-cloud-controller-manager chart is not a valid helm chart currently since it does not use a SemVer 2.0.0 version (due to the v prefix).

[apricote]

Hey @morremeyer,

thanks for reporting this. We are open for taking PRs on this.

Locations I can currently think of that need to be adjusted:

• hcloud-cloud-controller-manager/chart/Chart.yaml

  Line 4 in 8775196

  version: v1.18.0 # x-release-please-version

• hcloud-cloud-controller-manager/.goreleaser.yml

  Line 7 in 8775196

  - ./scripts/release-generate-deployment-yamls.sh {{ if not .IsSnapshot }}v{{ end }}{{ .Version }}

• hcloud-cloud-controller-manager/.goreleaser.yml

  Line 62 in 8775196

  cmd: ./scripts/publish-helm-chart.sh hcloud-cloud-controller-manager-{{ if not .IsSnapshot }}v{{ end }}{{ .Version }}.tgz

One additional thing to take care of is the image tag reference. The image tags DO contain the v and we currently use the Chart version as the tag. The v can be added to the default value:

hcloud-cloud-controller-manager/chart/values.yaml

Line 35 in 8775196

tag: '{{ $.Chart.Version }}'