ci: fix release assets not available #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default token GH_TOKEN in workflows does not trigger new events. We rely on the "tag" event created by release-please to build our release assets. By using a token for "hcloud-bot", the event will be properly created. We explicitly only run the workflow job if the repository is the main repo, as otherwise this workflow will fail in forks because the secret is not available.
samcday
reviewed
May 11, 2023
| @@ -6,10 +6,14 @@ name: release-please | |||
|
|
|||
| jobs: | |||
| release-please: | |||
| # The secret HCLOUD_BOT_TOKEN is only available on the main repo, not in forks. | |||
| if: github.repository == 'hetznercloud/hcloud-cloud-controller-manager' | |||
There was a problem hiding this comment.
Mm, we could also detect if the secret is set here, right? Not sure how hard we should work here to ensure releases can be cut for forks, though.
There was a problem hiding this comment.
Not sure how hard we should work here to ensure releases can be cut for forks, though.
Not at all in my opinion, thats why I just deactived the workflow for forks.
If left running for forks, this will create notifications of failing workflows for people having forks, i encountered this issue with the cluster-api-provider-hetzner.
samcday
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default token GH_TOKEN in workflows does not trigger new events. We rely on the "tag" event created by release-please to build our release assets.
By using a token for "hcloud-bot", the event will be properly created.
We explicitly only run the workflow job if the repository is the main repo, as otherwise this workflow will fail in forks because the secret is not available.
See also hetznercloud/cli#476