Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Release Assets are missing in v1.33.2 #476

Closed
apricote opened this issue May 8, 2023 · 1 comment · Fixed by #479
Closed

fix: Release Assets are missing in v1.33.2 #476

apricote opened this issue May 8, 2023 · 1 comment · Fixed by #479
Assignees
@apricote

Comments

@apricote
Copy link
Member

apricote commented May 8, 2023

The latest version v1.33.2 has no release assets because the release workflow was not triggered. We recently merged #473 to use release-please for tagging, but it looks like the tag from the workflow did not trigger another workflow. This is a well known restriction of the default Actions token:

When you use the repository's GITHUB_TOKEN to perform tasks, events triggered by the GITHUB_TOKEN, with the exception of workflow_dispatch and repository_dispatch, will not create a new workflow run.
@apricote apricote self-assigned this May 8, 2023
@apricote
Copy link
Member Author

apricote commented May 8, 2023

Fixed this manually for this release by re-creating the tag:

git push --delete gh v1.33.2
git push gh v1.33.2

Workflow is now running: https://github.com/hetznercloud/cli/actions/runs/4913027738

This was referenced May 9, 2023
Merged
Merged
apricote added a commit to hetznercloud/hcloud-cloud-controller-manager that referenced this issue May 11, 2023
@apricote
ci: fix release assets not available (#444)
1291b76 
The default token GH_TOKEN in workflows does not trigger new events. We
rely on the "tag" event created by release-please to build our release
assets.

By using a token for "hcloud-bot", the event will be properly created.

We explicitly only run the workflow job if the repository is the main
repo, as otherwise this workflow will fail in forks because the secret
is not available.

See also hetznercloud/cli#476
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apricote apricote

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: fix release assets not available hetznercloud/cli
1 participant
@apricote