Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make installer able to handle /dev/disk/by-id/ devices #56

Closed

Conversation

ableischwitz
Copy link

This change introduces the detection of DRIVEn /dev/disk/by-id/xxxx devices.
Additionally to the different nvme naming for partitions, those disks get a -partx added to the device - instead of a single number

Currently the installer simply adds a "1", "2",... to the device - which is fine for /dev/sda, /dev/sdb,* - there is already a exception for nvme devices, which also needs to be implemented for /dev/disk/by-id/* devices.
Not having this ability to provide static device names renders the installer to become unpredictable with 3 drives if only two of them should be configured.
This change also allows devices to be listed with their wwm-0x5xxxx name as they also reside in /dev/disk/by-id.

This change introduces the detection of `DRIVEn /dev/disk/by-id/xxxx' devices.
Additionally to the different nvme naming for partitions, those disks get a `-partx` added to the device - instead of a single number
@ableischwitz
Copy link
Author

With further testing, I found that the changes made, are not enough.

@guettli
Copy link

guettli commented Sep 7, 2023

Sad to hear that this was closed. Is there an alternative solution to use wwn/uuid in installimage?

@func0der
Copy link

@ableischwitz What else is not working?
These are similar findings to what I have found out.
The only thing broken for me seem to be the raid, which was relying on the partition id in the end of /dev/sdaX.

Could you elaborate?

@ableischwitz
Copy link
Author

@func0der I stopped following up on this as I solved that issue by running an ansible-playbook which identifies the devices and adjusts the install-config accordingly.
Due to the different naming for MD/NVME/* devices, the script may need some further adjustment to deal with all the special cases.

@func0der
Copy link

@func0der I stopped following up on this as I solved that issue by running an ansible-playbook which identifies the devices and adjusts the install-config accordingly. Due to the different naming for MD/NVME/* devices, the script may need some further adjustment to deal with all the special cases.

Thanks for getting back to me.
I think I have addressed all the places here: #92

If you have time and want to have a look at it, a 👍 might help to get it merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants