Add support for /dev/disk/by-id/.... notation in config #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces the detection of `DRIVEn /dev/disk/by-id/xxxx' devices. Additionally to the different nvme naming for partitions, those disks get a `-partx` added to the device - instead of a single number
Syntax for '/dev/disk/by-id' has '-partX' for the partition behind the drive paths. So we need to replace them here too, if found. Else the script would try to format the underlying drive and not the raid array, which would not work, because after joining the raid array the drive is constantly busy.
Closed
|
@asciiprod LGTM? :) |
|
Hello? |
|
There was another place which had to be adjusted, but in general it should work now. |
|
Thanks for merging. I just realized that I forgot to tick 'allow edits by maintainer' and wondered why the PR was not merged but rather the contents copied. Anyway: Glad the repo is alive and this feature made it in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #56
Relates to #30
Couple of remarks:
This script has multiple places where drives and partitions are handled. Almost all of them need to be aware of the
correct notation of partitions.
I think, that most of the time it is just a lucky hit, that it works.
Also the part where it either uses
p(nvme) or-partis in there at least twice, so parts of that script have been compatible with theby-idnotation already.I do not feel comfortable doing that kind of refactoring, though. Just wanted to mention that it might be a good idea to pull partition detection by name (or something) together some place.
Either way, I think this is a good start.