Test fixes

[moconnell]

No description provided.

[heueristik]

Hey, thanks for making a PR @moconnell.
Did you notice and take care that some tests were intentionally placed on the end of the year (the 31st of December) to account for edge cases?
Using the current date might render some tests useless, as the edge cases don't occur. Could you please check this?

[moconnell]

Hey @Michael-A-Heuer - the problem was that hard-coding the date in most of the tests to Dec 31st of the current year caused many of them to now fail due to the varying nature of which day of the week that turns out to be - in 2022, Dec 31 is a Saturday, which collides with how you setup the calendars!

What is the specific edge case you were trying to test?

[heueristik]

Oh, I see the problem. If I remember correctly, it tests meeting times that span from one year to the other (spanning two different months/years).

[moconnell]

Ok, I can add a test for that. Out of interest, was it that you actually saw problems with that case, or were you just being thorough? :)

[moconnell]

Ok, I basically reverted the two tests you are talking about. Turns out they weren't failing anyway, so good catch - thanks!

[moconnell]

Btw, are you active on the Raid Guild Discord still? Wondering where is best to continue discussions, if you have time/are still interested. I am part of the Season 4 cohort and have picked up this project as a first task.

Seems like there is not much left to do apart from actually deploy it and get the front-end talking to the back-end - correct?