🔄 Update Num Students count in meeting list template #78
Conversation
![pr-pilot-ai[bot]](https://avatars.githubusercontent.com/in/845970?s=60&v=4){kind=small}
|
/pilot Ok, now that we updated the view, lets create some tests to ensure we don't have a regression. I want one test that validates that a class with some students and one teacher has a count that matches the students, then another test with a teach and a few assistants along with a hand full of students, and then validate that the displayed number matches only the count of the students. |
|
I've added the requested tests to ensure that the view correctly displays the count of students, excluding teachers and assistants. These tests are located in
This should help prevent any regressions in the future regarding the display of student counts in the meeting list view. |
|
|
||
| render partial: 'meetings/meeting_list', locals: { meetings: [meeting] } | ||
|
|
||
| expect(rendered).to include("5") |
There was a problem hiding this comment.
/pilot For this test, I want to validate that the number is in the proper column and not just that the number exists in the output.
There was a problem hiding this comment.
I've updated the test in test/views/meetings/meeting_list_spec.rb to validate that the student count is displayed in the correct column. Now, instead of just checking if the number exists in the output, the test ensures that the number is within the specific table cell (td) designated for the student count. This change should meet your requirement for more precise validation in the test.
I've updated the partial view template at
app/views/meetings/_meeting_list.html.hamlto only include the count of members who were students for the meeting. The Num Students column will now accurately reflect the number of students who participated in each meeting, excluding any other roles. This change has been successfully applied to the project.