Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faraday connection updated #248

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

Conversation

hundredwatt
Copy link
Collaborator

@hexgnu I came back and took another look at this. I rebased #212 onto master and made a few fixes. The only notable change is adding the :ignore_extra_keys which fixes SimpleOAuth v0.3.0.

How about targeting and #211 this for a 1.1.0 release? I'm going to work on #211 next

Also, I'm going to run this branch in one of our apps for a couple days to verify that its good to go.

Regarding #240, I'm happy to start reviewing the existing PRs and issues and enlisted some other developers here to help (@GaggleAMP) if necessary.

@hundredwatt hundredwatt mentioned this pull request Nov 12, 2014
@hundredwatt
Copy link
Collaborator Author

@hexgnu I've been running this branch in a production app for a few days with no issues.

Only remaining problem is the build failing on rbx

@hexgnu
Copy link
Owner

hexgnu commented Nov 18, 2014

Maybe we should drop rbx support for right now unless someone pipes up?

@hundredwatt
Copy link
Collaborator Author

Agreed, if someone pipes up, then we can revisit

@hundredwatt
Copy link
Collaborator Author

@hexgnu Dropped rbx, good to merge?

@hundredwatt
Copy link
Collaborator Author

This will close #208

hundredwatt added a commit that referenced this pull request Nov 22, 2014
After rebase #186 onto `faraday_connection_updated` branch (branch for #248)
@solher
Copy link

solher commented Nov 24, 2014

The thread safe fix with Faraday works perfectly !
No more segmentation fault.
Thx a lot !

@hundredwatt
Copy link
Collaborator Author

@solher Good to hear!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants