fix: change expect #166
Closed
fix: change expect #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change expect from 2 inputs to 3 options as in lesson's instructions
|
тест не проходит |
dzencot
requested changes
Aug 1, 2022
| inputs.forEach((input) => { | ||
| expect(input).to.have.attr('type', 'text'); | ||
| }); | ||
| expect(options).to.have.length(3); |
There was a problem hiding this comment.
Тут изменено поведение теста. Это точно нужно? Опишите пожалуйста какую проблему это решает? Пока не очень понятно для чего убраны проверки инпутов и изменено количество в проверке
There was a problem hiding this comment.
@alvltab пишите, если нужна помощь по пулреквесту
There was a problem hiding this comment.
@alvltab Приветствую! Как дела пулреквестом? Нужна какая-то помощь?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change expect from 2 inputs to 3 options as in lesson's instructions